Zelmana Posted October 26, 2023 Share Posted October 26, 2023 In a few spots, we seem to sanitize apostrophes, but when they are displayed, it seems like they are not being properly decoded / surviving sanitization. Is this a viable thing that can be fixed? Maybe a htmldecode type deal? I don't code so I likely may be talking out of my ass. Examples, feel free to post additional: (Fuckup in STT enabled but not in directly writing it in the PDA message field) I'm not sure if this is a decent bounty amount? Anyone care to get a pot going we can, but 30USD is what I can give for this. Link to comment
Zelmana Posted October 26, 2023 Author Share Posted October 26, 2023 More catastrophe apostrophe Link to comment
Zelmana Posted October 26, 2023 Author Share Posted October 26, 2023 I believe records also have this issue- anyone care to post an example they find? Link to comment
MattAtlas Posted October 26, 2023 Share Posted October 26, 2023 I'll take a look at this tomorrow since I caused quite a few of these with tgui 5 Link to comment
Fluffy Posted October 27, 2023 Share Posted October 27, 2023 https://github.com/Aurorastation/Aurora.3/pull/17683 this (should) fix the announcements apostrophes for antags, and you can also have newlines too now; also should fix the PDA STT messages (assuming acceptance by maintainers, Arrow will check that all the necessary escaping works as intended) 4 Link to comment
Carver Posted October 27, 2023 Share Posted October 27, 2023 15 hours ago, Zelmana said: I believe records also have this issue- anyone care to post an example they find? I had this issue on the records for a Tajara I play, but I haven't read his records in-game in about a month. I'll try to get a screenshot at some point this weekend to verify if it persists. Link to comment
Zelmana Posted October 27, 2023 Author Share Posted October 27, 2023 14 hours ago, Fluffy said: https://github.com/Aurorastation/Aurora.3/pull/17683 this (should) fix the announcements apostrophes for antags, and you can also have newlines too now; also should fix the PDA STT messages (assuming acceptance by maintainers, Arrow will check that all the necessary escaping works as intended) If this passes review fine you've got 25USD, contact me on Discord. 5USD outstanding for a check on the records system, if the problem persists in records that is still available. Link to comment
Zelmana Posted October 27, 2023 Author Share Posted October 27, 2023 We have saints working here folks. 2 Link to comment
Fluffy Posted November 13, 2023 Share Posted November 13, 2023 PR is merged, it doesn't fix the signatures part, but announcements and PDA STT should be fixed 1 Link to comment
Carver Posted November 15, 2023 Share Posted November 15, 2023 On 27/10/2023 at 01:13, Carver said: I had this issue on the records for a Tajara I play, but I haven't read his records in-game in about a month. I'll try to get a screenshot at some point this weekend to verify if it persists. I took far too long to pinpoint a good time to get these screenshots, relevant as of the current time of posting: Spoiler Curiosities: The auto-generated name field correctly displays the apostrophe, the conversion from direct record doesn't. I used the same keyboard to write these records as I had used to type out the character's name when making him. Link to comment
Fluffy Posted November 16, 2023 Share Posted November 16, 2023 This should take care of the rest https://github.com/Aurorastation/Aurora.3/pull/17796 1 1 Link to comment
Fluffy Posted April 30 Share Posted April 30 The PR was merged and this "suggestion" is therefore considered implemented As a side note, this kind of things, however, are a bug, and should be reported on github, suggestions are for altering things that work as intended Locking and archiving Link to comment
Recommended Posts