Sorry, for the time it took to get back to that topic.
Ultimately DM knowledge is not the only deciding factor in a developer application.
Another important factor is "social compatibility" with the current team and the willingness to learn.
Therefore we are willing to accept people who might not have "great" knowledge of DM if they show the willingness to learn and the development team (as a whole) is willing to work with them.
In addition we (the headdevs) generally assign projects to people that allow them to learn various aspects of our codebase.
That has happened with drago during and after her developer trial and she has shown a good improvement in her DM skills since then.
Regarding the reviews:
All pull requests (with the exception of bugfixes) require at least two Reviews and have a waiting period of 3 days.
This ensures that more than one person reviews a PR and catches potential issues with the code and the reviews.
This system applies to both developer and contributor PRs.
Once a PR is in "awaiting merge" maintainer is needed to merge a pull request.
The only difference between developer and contributor reviews is that at least one approving developer review is required for a PR to reach the "awaiting merge" state.
In addition, if you have any concerns with a review given, you can contact the reviewer and/or the maintainers to clear up any questions you might have regarding it / correct it if needed.
(One example, where she gave a review which she later amended is not sufficient to warrant a removal from the dev team)
After a discussion with the rest of the development team, we do not see sufficient reason to remove her from the development team at this time.
I would also like to note a few things:
A staff complaint is not exactly appropriate to address concerns you might have about the performance of a staff member.
"For complaints against members of the staff team. Disagree with a judgement? Conduct? An action they've done? Post it here."
If you have issues with a decision they made or their conduct in their capacity as a developer, then a staff complaint would be appropriate.
For other cases it would be better to inform a headev/maintainer
We (headdevs) are aware of the difference in skill and activity between the developers.
I care very little about the concerns "people you have talked to" have regarding the performance of someone on the development team.
If they wish to express those concerns, they can approach a headdev/maintainer.
We do not prevent or punish anyone, including developers, from creating PRs that are controversial or not fully thought out.
We make use of draft PRs and the WIP flag (although the WIP flag should at some point be abandoned in favor of the draft PRs)
In the worst case the PR is closed without being merged and the creator of the PR wasted their time on it.
The only thing that would currently get you a repo ban is using github features in bad faith (which only happened 3 times so far, with two bans lifted)
Unless there are further comments I´ll close that complaint in 24h