Secret Random Gamemodes Cannot Be Chosen Twice In A Row

[BurgerBB]

https://github.com/Aurorastation/Aurora.3/pull/5808

[Resilynn]

10000% approve. 

[Enzayne]

What about deadhour? There are times where extended is currently the only available secret option during certain server times.

[LordPwner]

Burger you like the succ? This is how you get the succ. 

[Conspiir]

4 hours ago, Enzayne said:

What about deadhour? There are times where extended is currently the only available secret option during certain server times.

Have to second this. If there's no other option to pick, will this change still pick the gamemode a second time or will it fail to start?

[BurgerBB]

6 hours ago, Enzayne said:

What about deadhour? There are times where extended is currently the only available secret option during certain server times.

This will never occur.

[Enzayne]

That is factually incorrect. It happened to me earlier today.

Edit; Aka, a round got extended during secret deadhour. Round after had extremely low ready count and only had extended as an option despite being secret. 

Edited December 22, 2018 by Enzayne
Clarificqtion

[Scheveningen]

He's saying it'll never happen when the PR goes through, not that it doesn't happen right now, it is what is this PR is seeking to fix

[Enzayne]

But the problem here is that there is literally one gamemode available at some points during server uptime. As in, when secret starts, it says "possible gamemodes: extended" and nothing else. Because everything else requires more ready players.

Removing extended in this case would result in 0 available gamemodes. To say it will never happen is handwaving an actual issue.

Edited December 22, 2018 by Enzayne

[Scheveningen]

Yes, that is a concern. I do think extended should stay in the secret rotation no matter what tbh, as a default in case there weren't antagonists to run a functional gamemode.

[PoZe]

PR closed, project was discontinued.