Lady Fowl Posted December 16, 2018 Posted December 16, 2018 Ckey/BYOND Username: QueenOfYugoslavia Position Being Applied For: (coder, mapper, spriter): coder Past Experiences/Knowledge: Lua, 2+ Years DM Code: 6 Months, Moderate Experience Examples of Past Work: https://github.com/Aurorastation/Aurora.3/pull/5770 https://github.com/Aurorastation/Aurora.3/pull/5480 https://github.com/Aurorastation/Aurora.3/pull/5485 https://github.com/Aurorastation/Aurora.3/pull/5481 https://github.com/Aurorastation/Aurora.3/pull/5467 https://github.com/Aurorastation/Aurora.3/pull/5455 https://github.com/Aurorastation/Aurora.3/pull/5431 https://github.com/Aurorastation/Aurora.3/pull/5407 https://github.com/Aurorastation/Aurora.3/pull/5338 https://github.com/Aurorastation/Aurora.3/pull/5325 https://github.com/Aurorastation/Aurora.3/pull/5315 https://github.com/Aurorastation/Aurora.3/pull/5785 https://github.com/Aurorastation/Aurora.3/pull/5786 Preferred Mode of Communication (Skype, Steam, etc.): Discord Additional Comments:
Skull132 Posted December 18, 2018 Posted December 18, 2018 Will begin pestering developers for feedback on this one.
BurgerBB Posted December 19, 2018 Posted December 19, 2018 I was a little concerned about their conduct in the past but since then they've shown no issues. Not to soapbox or anything but any mishappenings in the past are just a droplet in a sea of piss compared to some of the things other staff (including me) have said and done. They know how to code it seems so eh, why not.
PoZe Posted December 20, 2018 Posted December 20, 2018 I haven't had any issues with the conduct. I think it is pretty normal for people at first to be like "WTF, I cannot code this?" or "Why can't we merge this? It's cool!", I mean I occasionally do it myself in devs chat. Anyways, Drago knows how to code and it is a plus. Their projects are good, they have few bugfixes as well.
Alberyk Posted December 20, 2018 Posted December 20, 2018 There is a major issue with your prs; you leave a lot of them unattended, mostly when there is too many requested changes or conflicts. Do you plan on changing this? Developers should also be reviewing prs, do you think you have enough knowledge on dm to help with this?
Scheveningen Posted December 20, 2018 Posted December 20, 2018 How much of an issue is that really exclusive to Drago, tho, considering the PRs on the last half of page 1 and 2? I don't really have an issue with this application. There's not really a metric somewhere to measure what competency level you need with DM code to be on a developer team, but the applicant has made meaningful and decent changes so far as a contributor. I don't see why not.
Lady Fowl Posted December 20, 2018 Author Posted December 20, 2018 1 hour ago, Alberyk said: There is a major issue with your prs; you leave a lot of them unattended, mostly when there is too many requested changes or conflicts. Do you plan on changing this? Developers should also be reviewing prs, do you think you have enough knowledge on dm to help with this? I went on a hiatus of sorts for abit in regards to the mentioned PR's, due to personal issues mostly where I was taking a break. I do plan on becoming active again. I feel confident aswell in helping reveiwing PR's aswell
MoondancerPony Posted December 21, 2018 Posted December 21, 2018 I have nothing but praise for Drago's work. They consistently produce quality code (if with a bit of assistance, but I needed some too when I started coding) and have a good creative vision, even if some of their ideas are a bit out there at times they're always enjoyable. (SecWays, anyone?) I also believe they're experienced enough with DM to review at least some basic PRs. Even I have difficulty understanding some of the back-end code at times, but I can just stay away from that or look for more obvious errors. I think they're certainly capable of doing good work as a developer.
Karolis2011 Posted December 24, 2018 Posted December 24, 2018 As far as I have look in to this application - I see that Drago has things that they could improve, but they already know quite a lot. I expect them to get better at DM over time, as they contribute more and more. I don't see them as extraordinary coder, but they will make a good coder, who should always be welcomed to a coder position.
Skull132 Posted February 2, 2019 Posted February 2, 2019 January has ended, so has this trial. Drago is now an official developer. Application accepted and archived.
Recommended Posts