Kaed Posted July 10, 2019 Share Posted July 10, 2019 I've noticed a trend lately where people put joke titles on PRs that are entirely misleading about the contents of the PR, like 'Removes X" when actually it's just a modification of said thing in some fashion. I'd like it it we injected a little bit more professionalism in PR documentation on out github, if that's not too much to ask, and have PRs actually labelled for what they do rather than the latest eye catching meme. Link to comment
KingOfThePing Posted July 10, 2019 Share Posted July 10, 2019 Yes. If I was a developer I would not want to be stripped away the possibility to name my PR what I wanted it to. If it gets more interesting from it and people click on it and actually read the exact changes, the better. I don't see any downside here. It is a literal click, people who are invested in github read the PRs anyway and people who get interested in it by some funny titles may get invested in github or the developing cycle/insights of the dev team more. Link to comment
Kaed Posted July 10, 2019 Author Share Posted July 10, 2019 18 minutes ago, KingOfThePing said: Yes. If I was a developer I would not want to be stripped away the possibility to name my PR what I wanted it to. If it gets more interesting from it and people click on it and actually read the exact changes, the better. I don't see any downside here. It is a literal click, people who are invested in github read the PRs anyway and people who get interested in it by some funny titles may get invested in github or the developing cycle/insights of the dev team more. Also, thank you for reporting my post, it kind of proves what I posted above. ? Funny titles are one thing, misleading titles are another entirely. You can make jokes without actually lying about what your PR is about to get attention. Link to comment
Scheveningen Posted July 10, 2019 Share Posted July 10, 2019 (edited) No. You want corporate-office degrees of seriousness and draconian enforcement of rules on every OOC platform, then go to Baystation. Edited July 10, 2019 by Scheveningen Link to comment
Kaed Posted July 10, 2019 Author Share Posted July 10, 2019 2 minutes ago, Scheveningen said: No. You want corporate-office degrees of seriousness and draconian enforcement of rules on their every OOC platform, go to Baystation. Yep, that's definitely the subject of this thread and not a slippery slope argument alongside guilt by association. Thank you for taking the time to read my thread and responding, delta. I'm not asking for total seriousness, just titles that actually tell us what the PR is about instead of eye-catching irrelevant memes. Link to comment
Scheveningen Posted July 10, 2019 Share Posted July 10, 2019 Again, no. Whether contributors choose to utilize clickbait titles or more informative titles is their prerogative. You're essentially asking to censor humorous titles because you don't find them funny enough. If you have an issue with this, you can just as easily X out, not use github and come back when you're not so irritable that your platform isn't "remove everything that isn't completely professional and to the point." The clickbait titles have the neat side effect of generating clicks to see what the proposed changes are in terms of content. They certainly fulfill their function and there have been exactly 0 people who have used the freedom with title-writing that have abused it to make racial slurs or other perceived slanders against members of the community, so there's no reason to take away that from anyone. Link to comment
Kaed Posted July 10, 2019 Author Share Posted July 10, 2019 (edited) 11 minutes ago, Scheveningen said: Again, no. Whether contributors choose to utilize clickbait titles or more informative titles is their prerogative. You're essentially asking to censor humorous titles because you don't find them funny enough. If you have an issue with this, you can just as easily X out, not use github and come back when you're not so irritable that your platform isn't "remove everything that isn't completely professional and to the point." The clickbait titles have the neat side effect of generating clicks to see what the proposed changes are in terms of content. They certainly fulfill their function and there have been exactly 0 people who have used the freedom with title-writing that have abused it to make racial slurs or other perceived slanders against members of the community, so there's no reason to take away that from anyone. Once again, I don't care how funny or not they are, my only relevant qualifier for this requested change is that the titles actually be indicative of the PR's contents. My personal grouchiness is not relevant here to the discussion. For example, "Ian Comes Home" is a recent PR title about switching the corgi plush in the HoP with Ian. It's certainly not that funny to me but it definitely tells you about the thread. "Removes CCIA" however, is a PR about changing the recording devices CCIA use, and is a misleading title that's only being used because 'removes X' is currently a meme in the PR subculture, presumably since the "Removes Skrell" PR thread happened months back. "Removes Xenos", however, certainly is actually removing Xenos, so that seems fine to me! Edited July 10, 2019 by Kaed Link to comment
Scheveningen Posted July 10, 2019 Share Posted July 10, 2019 It made you click, so mission accomplished. Even then, reading a description is not enough, reading the commits is far more important. Link to comment
Lady Fowl Posted July 10, 2019 Share Posted July 10, 2019 To just put my two cents in. Myself and every other developer adds new content for free because we enjoy the server. I dont see a issue with meme titles if its tasteful and semi related to the topic, but the actual pr desc needs to be serious and explain what it does Link to comment
Guest Marlon Phoenix Posted July 11, 2019 Share Posted July 11, 2019 1 hour ago, KingOfThePing said: If I was a developer Lol 51 minutes ago, DRagO said: the actual pr desc needs to be serious and explain what it does The title being related to the change would be good and the description wojld be so even better. Link to comment
Skull132 Posted July 11, 2019 Share Posted July 11, 2019 5 hours ago, Marlon Phoenix said: The title being related to the change would be good and the description wojld be so even better. You've got the priorities mixed. The description is responsible for providing a good enough overview of the PR (both the technical aspects and the purpose) for the developers reviewing and maintainers merging to know what they're acting on. The title has no such responsibility and largely serves as a discriminator. Which is why the way we've conducted ourselves thus far is that offensive titles get changed by maintainers and lacking descriptions result in a PR being stone walled until updated or declined. Link to comment
ben10083 Posted July 11, 2019 Share Posted July 11, 2019 I love meme PR titles, they bring a smile to my face, while also (usually) hinting at what the PR is. I feel the cons of enacting this suggestion outweigh the pro of not looking at desc to know what PR is. Link to comment
UnknownMurder Posted July 11, 2019 Share Posted July 11, 2019 As an Aurora non-developer but a having a computer science major in real world wandering around on GitHub once a while to see what's been changed, improved and removed. Funny PR titles do get me addicted and gives me the desire to read the PR description and sometimes the commit. I'm with @Scheveningen as a whole on this. Aurora Master Branch on GitHub is just like YouTube but without anime girls clickbaits. Give me a funny/meme/punny/MetalGearSolid/anime/otaku title and I'm more prone to reading your PR. @Kaed, due with all respect. I think you're just in a bad mood when reading the PRs and making this thread. Fun is allowed on GitHub and Aurora Station Forums. @KingOfThePing Link to comment
KingOfThePing Posted July 11, 2019 Share Posted July 11, 2019 Yes. That's why I posted a clearly sarcastic picture. I fully agree with what you said. Link to comment
Azande Posted July 12, 2019 Share Posted July 12, 2019 Yeah uh, as long as the changelog and the content of the PR is clear - the name is basically irrelevant. You can just quickly open a PR if you're confused. Link to comment
Carver Posted July 17, 2019 Share Posted July 17, 2019 (edited) My only issue with the names is sometimes I click on it from the meme name, and assume that the contents within are influenced to further the 'intent' (even if not the genuine intent) of the title, and I have a naturally adverse reaction to it. Something says 'removes x', then within it goes 'changes x in y way' and I assume the intent of said change is to negatively affect/weaken/nerf x regardless from the title. Memes are fine, but let there be some clarity in intent present in the title itself. Otherwise it sets the precedent that I cannot accurately assume any measure of truth to be held in the titles of PRs. Edited July 17, 2019 by Carver Dumb thought, just make meme titles require an obligatory (/s) at the end of them. Link to comment
Arrow768 Posted May 10, 2020 Share Posted May 10, 2020 Seconding Skull here and moving it to rejected policy suggestions. The description of the PR needs to explain what the PR is about. The title should be related or it will get changed by the maintainers. Link to comment
Recommended Posts